Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updater thread + Updater related functions #253

Merged
merged 16 commits into from
Nov 18, 2019

Conversation

yeastplume
Copy link
Member

@yeastplume yeastplume commented Nov 6, 2019

Continuing work as per RFC at mimblewimble/grin-rfcs#30. This PR:

  • Adds functions to the owner API to stop and start the updater thread
  • Modifies other functions that might update the wallet to not attempt update if the updater thread is running
  • Modifies utxo scanning to send status update messages to an mpsc sender instead of logging
  • Provide functions to return status update messages
  • changes default selection strategy to 'smallest'
  • Test additions and updates

@yeastplume yeastplume changed the title [WIP] Add updater thread + functions Add updater thread + Updater related functions Nov 15, 2019
@yeastplume yeastplume merged commit e74c0e2 into mimblewimble:master Nov 18, 2019
@yeastplume yeastplume deleted the update_thread branch January 6, 2020 09:57
yyangli pushed a commit to mwcproject/mwc-wallet that referenced this pull request May 13, 2020
* first attempt at adding updater thread

* rustfmt

* rustfmt

* many lifetimes made static to allow api to spawn separate thread

* add first pass at updater thread functionality

* rustfmt

* add mpsc for returning status from update functions

* rustfmt

* add stop state, ensure update is triggered by wallet functions when wallet updater is running

* rustfmt

* add update status function to owner API, V3 owner api functions

* rustfmt

* change update warning

* adding tests for new updater control functions

* documentation updates

* rustfmt
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
* first attempt at adding updater thread

* rustfmt

* rustfmt

* many lifetimes made static to allow api to spawn separate thread

* add first pass at updater thread functionality

* rustfmt

* add mpsc for returning status from update functions

* rustfmt

* add stop state, ensure update is triggered by wallet functions when wallet updater is running

* rustfmt

* add update status function to owner API, V3 owner api functions

* rustfmt

* change update warning

* adding tests for new updater control functions

* documentation updates

* rustfmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants