Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual recovery #268

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Conversation

yeastplume
Copy link
Member

This changes the recover command to display the recovery phrase only. A much more intuitive and non confusing recovery can be done with init -r now, which will automatically restore via the scan command on first run after recovery.

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Minor comment below.

#[serde(with = "secp_ser::string_or_u64")]
pub ttl_cutoff_height: u64,
#[serde(with = "secp_ser::opt_string_or_u64")]
pub ttl_cutoff_height: Option<u64>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrelated but probably fine though #267 ?

@yeastplume yeastplume merged commit 56396b8 into mimblewimble:master Dec 3, 2019
@yeastplume yeastplume deleted the remove_recover branch January 6, 2020 09:57
yyangli pushed a commit to mwcproject/mwc-wallet that referenced this pull request May 13, 2020
* remove recovery command

* Remove manual recovery option from command line

* rustfmt
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
* remove recovery command

* Remove manual recovery option from command line

* rustfmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants