Fix: Log update thread do not exit after call ownerAPI. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just looking at this now, and it seems like this change would allow the thread to exit when the sender channel goes out of scope (as opposed to the parent thread going out of scope,) but I'm left guessing as to what the intent is. It would help if you could submit a clearer, more detailed description of what the symptoms are for the issue that this fixes and why you believe this change is needed. |
|
I've looked at this and the suggested behaviour is correct (the loop in the log thread exits otherwise). Going to merge this into master but also cherry-pick to 3.0.1. Thanks for pointing this out! |
yeastplume
pushed a commit
to yeastplume/grin-wallet
that referenced
this pull request
Jan 16, 2020
yeastplume
added a commit
that referenced
this pull request
Jan 17, 2020
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log update thread do not exit after call ownerAPI.