Grin hypen wallet #297
Merged
Grin hypen wallet #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinlesceller
requested changes
Jan 17, 2020
There was a problem hiding this comment.
Thank you for the PR @mplsgrant! Overall 👍. However, i'm not sure we want to mix a cargo update with this PR though. So can you not include the Cargo.lock file? Thank you.
|
Thank you for reviewing the PR. I removed the changes to Cargo.lock. |
quentinlesceller
approved these changes
Jan 17, 2020
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* Automatic changes to Cargo.lock resulting from: cargo update. * Changed 'grin wallet' to 'grin-wallet'. * Removed Cargo.lock changes from PR 'Grin hypen wallet mimblewimble#297'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I believe that at some point people separated Grin Wallet from Grin and moved it into its own grin-wallet repository; however, some user-facing references to "grin wallet" remain.
Changes
I changed some user-facing instances of "grin wallet" to "grin-wallet"
Rationale and scope
I only changed instances of "grin wallet" where the user gets a direct instruction from grin-wallet. I focused on only those instances because the user should get correct and unambiguous instructions from grin-wallet. I left unchanged any "grin wallet" instances that would fall only under the purview of brand such as whether to use the words "Grin wallet", "Grin Wallet", "grin wallet", "the grin wallet", etc.