Secure API JSON RPC ID can be integer or string #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinlesceller
changed the title
|
Looks good (small test complication failure), but I'm wondering if it's more correct to leave the id as a u32 and just provide a 'string_or_u32' formatter as well. JS usually only supports 32 bit literals (which is why all u64s throughout the API are returned and accepted as strings). |
|
True, that's one way to do it. But since easyjson-rpc https://github.com/mimblewimble/easy-jsonrpc/blob/master/src/lib.rs#L468 uses u64 internally, wouldn't it be logical to also use u64? |
|
Yeah, I don't think it makes a huge difference. Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312 and #313.
uint64 are now serialized as string and can be deserialized either from integer or string.