Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework directory checks/setups at launch #318

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Rework directory checks/setups at launch #318

merged 3 commits into from
Jan 31, 2020

Conversation

yeastplume
Copy link
Member

Reworks initial directory setup logic and the flow of the init command to:

  • That the --top-level-dir switch is respected appropriately
  • That the api secret files aren't written to default locations when using the --top-level-dir switch or initting a wallet in the current directory (these were erroneously being created in the ~./grin/main dirs)
  • Check for the presence of an existing configuration file before asking user for a password/recovery phrase, and exit if so.

Fixes #308 and #279

quentinlesceller
quentinlesceller approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me 👍. Also tested both scenarios (#308 and #279) and can confirm it fix it. Minor comment on a particular syntax.

config/src/config.rs Show resolved Hide resolved
@yeastplume
Copy link
Member Author

Excellent, thanks very much for reviewing and testing.

@yeastplume yeastplume merged commit e71d79d into mimblewimble:master Jan 31, 2020
@yeastplume yeastplume mentioned this pull request Jan 31, 2020
Closed
@yeastplume yeastplume mentioned this pull request Feb 14, 2020
Closed
@yeastplume yeastplume deleted the setup_fixes branch March 3, 2020 08:37
antiochp pushed a commit to antiochp/grin-wallet that referenced this pull request Aug 7, 2020
@yeastplume
Rework directory checks/setups at launch (mimblewimble#318)
467a11e 
* rework setup code to ensure --top_level_dir flag works and all files are only output into the desired directory

* check for existence of wallet configuration file in target directory before asking recovery phrase and password

* test fixes and add test_mode flag to parse_init_args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

top_level_dir continues to broken
2 participants
@yeastplume @quentinlesceller