Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix our lmdb iter usage to work with changes in grin #522

Merged

Conversation

antiochp
Copy link
Member

@antiochp antiochp commented Oct 7, 2020

Our low level lmdb iter usage changed in mimblewimble/grin#3450

This PR reworks the wallet usage of db.iter() to reflect these changes.

This is just to get everything compiling. We should revisit this as the interface is a little awkward right now.

@antiochp
Copy link
Member Author

antiochp commented Oct 7, 2020

The full walllet test suite ran locally for me.
I'm guessing our test coverage of the various iter() calls in the db is relatively good here.

@antiochp antiochp requested a review from yeastplume October 7, 2020 22:20
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Merging.

@quentinlesceller quentinlesceller merged commit 7f5c010 into mimblewimble:master Oct 8, 2020
@antiochp antiochp deleted the iter_changes_from_grin branch October 8, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants