Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.x] Fix owner API scan #573

Merged
merged 1 commit into from
Jan 14, 2021
Merged

[5.0.x] Fix owner API scan #573

merged 1 commit into from
Jan 14, 2021

Conversation

jaspervdm
Copy link
Contributor

When introducing the fix in #552 we missed the scan api method, since it uses a FuturesUnordered instead of Client::send_request.

Fixes #559.

@jaspervdm jaspervdm mentioned this pull request Jan 14, 2021
Closed
quentinlesceller
quentinlesceller approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this fix common issues encoutered with the wallet owner api. LGTM and release v5.0.3.

@quentinlesceller quentinlesceller merged commit a03d425 into mimblewimble:current/5.0.x Jan 14, 2021
@quentinlesceller quentinlesceller mentioned this pull request Jan 14, 2021
Closed
quentinlesceller pushed a commit to quentinlesceller/grin-wallet that referenced this pull request Mar 5, 2021
@jaspervdm @quentinlesceller
Fix owner API scan (mimblewimble#573)
07b55ba
@quentinlesceller quentinlesceller mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinlesceller quentinlesceller quentinlesceller approved these changes

@antiochp antiochp Awaiting requested review from antiochp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaspervdm @quentinlesceller