Replace failure with thiserror
#654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyro
approved these changes
Jul 28, 2022
| let version = SlateVersion::V4; | ||
| Ok(VersionedSlate::into_version(slate, version).map_err(|e| e.kind())?) | ||
| VersionedSlate::into_version(slate, version) |
There was a problem hiding this comment.
👍 for removing redundant unwrap->wrap. I think there are a few more above in functions build_coinbase, receive_tx, finalize_tx in api/src/foreign_rpc.rs
|
All good, many thanks for reviewing! |
bayk
added a commit
to mwcproject/mwc-wallet
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet counterpart for mimblewimble/grin#3728, note that the node PR will need to be merged before this will compile.
All should be as before, except
thiserrordoesn't support explicit backtraces so these have been removed from test output where they appeared.Review should again just check to ensure I haven't accidentally changed any logic.