offline build not possible right now closes #2139 #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rentenmark
commented
Dec 12, 2018
rentenmark
commented
- remove (almost) all unwrap calls
- replace with ? operator
- build script will now work offline and in many other scenarios where the web wallet may not be downloaded
* remove (almost) all unwrap calls * replace with ? operator * build script will now work offline and in many other scenarios where the web wallet may not be downloaded
rentenmark
commented
Dec 12, 2018
| let web_wallet_install = install_web_wallet(); | ||
| match web_wallet_install { | ||
| Ok(true) => {} | ||
| _ => println!( |
There was a problem hiding this comment.
Note that this message will probably never be seen and thus we should probably consider deleting messaging in any case where the build script will return 0 status code.
antiochp
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.