I2P support #2745
I2P support #2745
Conversation
Adds necessary configuration bits to enable I2P in various modes, unused for now but will soon. Also add peer address wrappers for I2P so those addresses can be understood and exchanged between peers. Doesn't compile yet as serde needs to be supported in i2p-rs first.
p2p/src/types.rs
Outdated
| /// Whether this is an classic IP address | ||
| pub fn is_ip(&self) -> bool { | ||
| if let PeerAddr::I2p(_) = self { | ||
| return true; |
There was a problem hiding this comment.
shouldn't it be false? or just replace the body with !self.is_i2p()
There was a problem hiding this comment.
Good catch! Will fix.
|
What remains on this PR? Would really love to start testing this out, and get Grin running over I2P by default. Is there anyway I can help? |
|
@ignopeverell I started work on rebasing this branch on current master (1.1.0-beta2 - b9db129), and completing the remaining P2P work (per our discussion on Gitter). Submitted a PR against your branch with my rebase work (basically just minor fixups), to make further collaboration/merging a bit easier. |
|
@ignopeverell ping. I removed the rebase onto 1.1.0 (now it's still on 1.0.3), and completed a large amount of remaining work for I2P connections. Please review the work in that PR, and merge if you approve. After the merge, a rebase onto 1.1.0 would be immensely helpful for future collaboration. Thank you for your initial work in supporting I2P. |
|
Closing that PR since we are going in another direction. Hope you'll understand @ignopeverell :) |
See #2712 for background.