Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary newline in Stratum message #3315

Merged
merged 1 commit into from
May 21, 2020
Merged

Remove unnecessary newline in Stratum message #3315

merged 1 commit into from
May 21, 2020

Conversation

quentinlesceller
Copy link
Member

Found out here #1215.
This line of code send an empty message. We don't the need the newline here.
Tested and this fix the issue.

@quentinlesceller quentinlesceller requested a review from jaspervdm May 1, 2020 19:15
@quentinlesceller quentinlesceller mentioned this pull request May 2, 2020
Closed
@quentinlesceller
Copy link
Member Author

Can confirm this is causing some error on NiceHash too.

@quentinlesceller quentinlesceller merged commit 5d0791b into mimblewimble:master May 21, 2020
@quentinlesceller quentinlesceller deleted the newline branch May 21, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashmap hashmap hashmap approved these changes

@jaspervdm jaspervdm Awaiting requested review from jaspervdm

Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quentinlesceller @hashmap