-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testnet1] sync head & improved fork handling #413
Merged
antiochp
merged 13 commits into
mimblewimble:milestone/testnet1
from
antiochp:sync_head_testnet1
Dec 1, 2017
Merged
[testnet1] sync head & improved fork handling #413
antiochp
merged 13 commits into
mimblewimble:milestone/testnet1
from
antiochp:sync_head_testnet1
Dec 1, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass in sync and head contexts to pipe
fix put the 1s sleep back in... let sync run even if the full 512 headers are all known give sync a chance to sync against a fork that forked a long time ago
block validaton should not check for height+1 based on head no assumptions should be made about height indices
…height against ctx head)
This should be ready to go - tests were failing in chain (now fixed) and grin.
|
Seeing this in the test logs. Something looks wrong here as this genesis hash is for
|
Should be fixed now. Waiting to see if tests pass on travis... |
This was referenced Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync_head
that we use to track the longest fork on the peer with most work>height+1
based on current head (see Fix block locator with long forks #402 for discussion)check_known
insync_block_header
- we always want to (re)-process headers when syncing as we can jump from fork to fork depending on connected peersvalidate_block
(height may jump across forks)validate_block
get_header_by_height
(height may jump across forks)setup_height