add appveyor, find libnode for any nodejs version #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
develar
commented
Nov 15, 2018
| @@ -28,20 +28,22 @@ function buildLaunchUI() { | |||
| const nodeDir = path.join( __dirname, '../deps/node' ); | |||
| const libuiDir = path.join( __dirname, '../deps/libui' ); | |||
|
|
|||
| const nodeSrc = path.join( nodeDir, process.platform == 'darwin' ? 'out/Release/libnode.57.dylib' : 'out/Release/lib.target/libnode.so.57' ); | |||
There was a problem hiding this comment.
On linux here now 64 for NodeJS, not 57. To avoid such dependency, I added reliable way to find libnode file. Just scan dir and find by mask.
There was a problem hiding this comment.
You can use the getNodeModuleVersion() function from utils.js, it returns the node version. It's used in build-node.js but I forgot to replace it here.
|
Please note that currently you can build LaunchUI on macOS because of andlabs/libui#422 I am not going to fix it because I don't need LaunchUI for macOS. |
develar
commented
Nov 17, 2018
| @@ -54,3 +55,13 @@ function buildLaunchUI() { | |||
| if ( result.error != null ) | |||
| throw result.error; | |||
| } | |||
|
|
|||
| function symlinkIfNotExist( src, dest ) { | |||
There was a problem hiding this comment.
Old check was not enough and doesn't work. Now you can run npm run build:libui several times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of electron-builder support for Proton Native and libui frameworks, I have forked this repo to build for latest node LTS.
Because of security reasons, it is bad to build locally, so, appveyor is added (~30 minutes to build).