Timestep Arrays View #963
Merged
Timestep Arrays View #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #963 +/- ##
==========================================
- Coverage 85.12% 84.83% -0.30%
==========================================
Files 40 40
Lines 4041 4055 +14
==========================================
Hits 3440 3440
- Misses 601 615 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
davidanthoff
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two methods to call
viewonTimestepArraytypes, only two for now at the most general level. They should work for all instances, though I have not yet implemented matchingviewmethods for all of the possible permutations of arguments, like forTimestepVectorandTimestepArray, which may improve performance.I do note that used with too many dimensions and
:thisviewmethod can be type unstable, butgetindexwith the same arguments and indices is also type unstable. This is something I'd like to work on tackling in a next PR but I don't think this exacerbates the issue, it just sometimes adds a tradeoff between memory allocation and type stability which is admittedly not ideal.