Remove deprecated dependency on container-interop #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container-interop is an extension of the PSR-11 psr/container package. By depending on that interface, we cover more possible PSR-11 containers. Containers still implementing containter-interop remain untouched, as the interface is a mere extension of the psr-11 interface. Fix interface in test
|
Thanks, @Brammm ! In your opinion, is this a breaking change, or can we safely pass it off as a minor release? |
|
@mindplay-dk I'm pretty sure this is non-breaking, as container-interop simply extends psr/container. The only way it would be breaking is if someone used a container that locks to container-interop 1.0.0 or 1.1.0 (the update to extend psr/container was made in 1.2.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container-interop is an extension of the PSR-11 psr/container package. By depending on that interface, we cover more possible PSR-11 containers. Containers still implementing containter-interop remain untouched, as the interface is a mere extension of the psr-11 interface.