Skip to content
This repository has been archived by the owner on Feb 1, 2019. It is now read-only.

Feedback loop duplicates #237

Merged
merged 3 commits into from
Aug 30, 2017
Merged

Feedback loop duplicates #237

merged 3 commits into from
Aug 30, 2017

Conversation

samhstn
Copy link
Contributor

@samhstn samhstn commented Aug 29, 2017

Ref #181

@samhstn samhstn self-assigned this Aug 29, 2017
@samhstn samhstn assigned SimonLab and Danwhy and unassigned samhstn, SimonLab and Danwhy Aug 29, 2017
@dwylbot
Copy link

dwylbot bot commented Aug 29, 2017

⚠️ @Shouston3, the pull request is in "awaiting-review" but doesn't have a correct assignee.
Please assign someone to review the pull request, thanks.

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

3 similar comments
@dwylbot
Copy link

dwylbot bot commented Aug 29, 2017

⚠️ @Shouston3, the pull request is in "awaiting-review" but doesn't have a correct assignee.
Please assign someone to review the pull request, thanks.

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot
Copy link

dwylbot bot commented Aug 29, 2017

⚠️ @Shouston3, the pull request is in "awaiting-review" but doesn't have a correct assignee.
Please assign someone to review the pull request, thanks.

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@dwylbot
Copy link

dwylbot bot commented Aug 29, 2017

⚠️ @Shouston3, the pull request is in "awaiting-review" but doesn't have a correct assignee.
Please assign someone to review the pull request, thanks.

Any questions, complaints, feedback, contributions?
Discuss
If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

@samhstn samhstn mentioned this pull request Aug 29, 2017
Open
Danwhy
Danwhy reviewed Aug 29, 2017
View reviewed changes
cms/static/js/feedback.js Outdated
@@ -56,8 +85,9 @@ function remove_visited(id) {
}

function delete_visited(id) {
console.log('DELETE');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩

@Danwhy Danwhy removed their assignment Aug 29, 2017
SimonLab
SimonLab approved these changes Aug 30, 2017
View reviewed changes
Copy link
Contributor

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonLab SimonLab merged commit 0a0d087 into rewrite Aug 30, 2017
@SimonLab SimonLab deleted the feedback-loop-duplicates branch August 30, 2017 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Danwhy Danwhy Danwhy approved these changes

@SimonLab SimonLab SimonLab approved these changes

Assignees
No one assigned
Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samhstn @SimonLab @Danwhy