Check the blob size instead of the progress reports #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we can access the blob before the ready state is DONE, so the progress bar will remain slightly off in firefox. update: tested it, yes, response is null before DONE state. |
pschichtel
force-pushed
the
bugfix/firefox-downloads
branch
from
7b48c1c
to
5272a4b
Compare
|
Meh, so the dependency vulnerability check fails, but I definitely haven't touched any dependencies. Maybe this rebase helps? |
pschichtel
force-pushed
the
bugfix/firefox-downloads
branch
from
6ae2a86
to
158406e
Compare
cesnietor
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Makes so much sense.
Thanks for figuring it out @pschichtel.
I've tested it in Chrome, Firefox and Safari. For complete downloads as well as incomplete ones.
All works as expected.
cesnietor
requested review from
dvaldivia,
prakashsvmx,
bexsoft and
kaankabalak
prakashsvmx
approved these changes
Feb 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3243
I just had the epiphany to just simply check the size of the blob which carries the downloaded content, since that has already been decompressed by the browser.