Improve trace stats #5095
Merged
Improve trace stats #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows traces to be replayed in stats mode from `mc admin trace -json ALIAS >trace.json`, using `mc admin trace -in=trace.json`. `.zst` are automatically decompressed. This is replayed at full speed, since I don't really see any value in keeping original speed. Add scrolling to stats. Up+Down+Home+End Add 'r' to reset min/max stats.
harshavardhana
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows traces to be replayed in stats mode from
mc admin trace -json ALIAS >trace.json, usingmc admin trace -in=trace.json. Also.zstare automatically decompressed.This is replayed at full speed, since I don't really see any value in keeping original speed.
Add scrolling to stats. Up+Down+Home+End
Add 'r' to reset min/max stats.
How to test this PR?
See instructions above.
Types of changes