Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call getGPUTier when animation is disabled #1091

Open
wants to merge 1 commit into
base: mds-v1
Choose a base branch
from

Conversation

ramondeklein
Copy link

@ramondeklein ramondeklein commented Nov 6, 2024

When background animation is disabled, the getGPUTier() function was still invoked. This results in a call to an external site and we should allow to disable it.

PS: We probably should also fix this in the current master release. This is just fixing the branch that is used by upstream MinIO console.

@ramondeklein ramondeklein self-assigned this Nov 6, 2024
@ramondeklein ramondeklein marked this pull request as draft November 6, 2024 19:23
@ramondeklein ramondeklein changed the base branch from master to mds-v1 November 6, 2024 19:23
@ramondeklein
Copy link
Author

I'm not able to debug this. I thought this was a 5 minute fix, but yarn doesn't seem to allow debugging imported pacakges. This has to wait until later...

@p1r4t3-s4il0r
Copy link

Hello @ramondeklein
Do you have when you ll have time to have a deeper look ?

Thanks

@ramondeklein ramondeklein marked this pull request as ready for review November 15, 2024 13:04
@ramondeklein
Copy link
Author

@bexsoft @bayasdev Please review, so we can merge this in upstream console.

PS: We should also create a PR to remove this call from master, because we don't use animated login in AIStor.

@bayasdev
Copy link
Collaborator

PS: We should also create a PR to remove this call from master, because we don't use animated login in AIStor.

We do actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants