Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in 6.0.3 for ListObjectsAsync #1115

Closed
RobSlgm opened this issue Jun 27, 2024 · 4 comments · Fixed by #1116
Closed

Breaking changes in 6.0.3 for ListObjectsAsync #1115

RobSlgm opened this issue Jun 27, 2024 · 4 comments · Fixed by #1116
Assignees
Labels

Comments

@RobSlgm
Copy link

RobSlgm commented Jun 27, 2024

With 6.0.3 a call of client.ListObjectsAsync(args, ct)fails to compile. It compiled and worked with 6.0.2.

#1049 introduces a Minio.ApiEndpoints.CompatibilityExtensions which maps some ListObjectsAsync calls to the new ListObjectsEnumAsync. The calls with an CancellationToken are missing.

@ebozduman
Copy link
Collaborator

looking into it...

ramondeklein added a commit to ramondeklein/minio-dotnet that referenced this issue Jun 27, 2024
@ramondeklein ramondeklein linked a pull request Jun 27, 2024 that will close this issue
@ramondeklein
Copy link
Contributor

It was a mistake to add IObservable<T> with a cancellation-token in the first place, so you should probably not want to use this. If you want to cancel an observable, then you should dispose the subscription. Submitted #1116 to bring back the cancellation token.

@RobSlgm Instead of using the cancellation token, I would highly recommend to cancel the subscription instead. That's the proepr solution. Cancellation tokens are meant to be used with async programming (using tasks). When using IObservable<T>, then stick with that.

ramondeklein added a commit to ramondeklein/minio-dotnet that referenced this issue Jun 27, 2024
@ebozduman ebozduman reopened this Jun 29, 2024
@harshavardhana
Copy link
Member

Why is this reopened?

@ebozduman
Copy link
Collaborator

Sorry! It is a mistake.
I did not even realize I've reopened it.
My fingers are not listening to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants