Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using interface IReadOnlyDictionary instead of a dicrionary in TagSet and Tagging #1149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

using interface IReadOnlyDictionary instead of a dicrionary in TagSet and Tagging #1149

wants to merge 2 commits into from

Conversation

danilenko-a
Copy link

Interface limitation: The dictionary with tags is only needed for enumeration.

ebozduman
ebozduman requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 more occurrences of the same IDictionary structure.

Minio/DataModel/
|==> ILM/AndOperator.cs at line#45 (on master branch)
|==> Replication/AndOperator.cs at line#53 (on master branch)

using interface IReadOnlyDictionary instead of a IDictionary in DataM…
5274a26 
…odel/ILM/AndOperator.cs and DataModel/Replication/AndOperator.cs
@danilenko-a
Copy link
Author

Pull request updated

@ebozduman
Copy link
Collaborator

That's great @danilenko-a!
Could you also add some functional test(s) for this PR/change?
Maybe, you can do the testing simply by adding some assertions or checks in existing functional tests about Tags, ILM and Replication where IReadOnlyDictionary is introduced.
Please make sure the tests/checks are created for .../minio-dotnet/Mino.Functional.Tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilenko-a @ebozduman