Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed time zone lost when serializing and parsing dates #811

Conversation

basrach
Copy link
Contributor

@basrach basrach commented Jul 31, 2023

Fixes #810 and #808

@ante-maric
Copy link

I would suggest that the whole library should work only with UTC and that names of parameters and properties clearly state that by using UTC suffix which is common convention. That would greatly simplify things. Working with local time bites you sooner or later.

@martijn00
Copy link
Contributor

@ebozduman this looks good to go to me

@martijn00
Copy link
Contributor

@basrach Try to do a Rebase instead of merge to fix the code style.

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman ebozduman merged commit 023ec7e into minio:master Aug 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RetentionUntilDate in SetObjectRetentionArgs serialized to wrong value
5 participants