listen bucket: Support empty events from the server #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
force-pushed
the
fix-less-length
branch
from
d841110
to
870a486
Compare
Ask the server to send empty events in Listen Bucket API With older MinIO versions, this would clear the whitespaces for the scanner buffer, many whitespaces will make the scanner complains as it needs a new line to clear some internal buffer. With new MinIO version, ping=10 query will be considered and the server will send empty events, instead of the whitespaces, each 10 seconds.
vadmeste
force-pushed
the
fix-less-length
branch
from
870a486
to
56e7153
Compare
harshavardhana
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask the server to send empty events in Listen Bucket API
With older MinIO versions, this would clear the whitespaces for the
scanner buffer, many whitespaces will make the scanner complains as it
needs a new line to clear some internal buffer.
With new MinIO version, ping=10 query will be considered and the server
will send empty events, instead of the whitespaces, each 10 seconds.