api: Create new pkg/encrypt package and use it. #641
Conversation
harshavardhana
force-pushed
the
encrypt-decrypt
branch
4 times, most recently
from
96a9087
to
e80ac3d
Compare
| // save in the object metadata | ||
| type EncryptionMaterials interface { | ||
| // Materials - provides generic interface to encrypt any stream of data. | ||
| type Materials interface { |
There was a problem hiding this comment.
'Materials' could be more generic without GetIV(), GetKey() and GetMatDesc().
Think about it this way: any encryption module can save any information it wants in headers, that information will be retrieved from headers later to decrypt data.
As this becomes a separate package, I think we can replace http.Header with map[string]string.
type Materials interface {
Read(b []byte) (int, error)
SetupEncryptMode(stream io.Reader) (map[string]string, error)
SetupDecryptMode(stream io.Reader, decryptInfo map[string]string) error
}
There was a problem hiding this comment.
An IV and Key are much to do with Crypto rather than to do with AWS, AWS SPEC just names them properly and uses them.
So it is correct the way it is right now, perhaps i can change it.. further.
api-get-object.go
Outdated
| @@ -44,8 +46,10 @@ func (c Client) GetEncryptedObject(bucketName, objectName string, encryptMateria | |||
| return nil, err | |||
| } | |||
|
|
|||
| encryptMaterials.SetupDecryptMode(encReader, st.Metadata) | |||
| // Start decrypting the object. | |||
There was a problem hiding this comment.
Decryption doesn't start here actually, this is just a setup. Data are decrypted when Read() is called.
This is implemented to avoid references of any HTTP or aws based constants. Simply to show that encryption is implemented for generic purposes.
harshavardhana
force-pushed
the
encrypt-decrypt
branch
from
e80ac3d
to
a226c55
Compare
This is implemented to avoid references of any
HTTP or aws based constants. Simply to show that
encryption is implemented for generic purposes.