Make some changes to PutObjectStreaming() API #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
multipart-streaming
branch
2 times, most recently
from
bb44387
to
ad58937
Compare
|
This PR also fixes the bug #658 |
harshavardhana
force-pushed
the
multipart-streaming
branch
2 times, most recently
from
16dda0e
to
f1972e7
Compare
vadmeste
reviewed
Apr 23, 2017
api-put-object-progress.go
Outdated
|
|
||
| // If size cannot be found on a stream, it is not possible | ||
| // to upload using streaming signature. | ||
| if size < 0 { |
There was a problem hiding this comment.
Can't we use multipart upload when we don't know the full size of the object?
- miniog-go calls NewMultipartUpload which doesn't require to know the size of the object
- minio-go tries to read at least 64MiB from io.Reader before it uploads the part.
- then CompleteMultipartUpload
We need to disable parallel uploads here, also resuming upload should be avoided which means we need to create a new upload id each time we call PutObjectStreaming.
We can do this in a separate PR since there is no API breakage.
There was a problem hiding this comment.
Good idea will do, perhaps in a separate PR.
There was a problem hiding this comment.
@harshavardhana we should close #607 once @vadmeste's comments are addressed. This PR fixes #658.
krisis
approved these changes
Apr 24, 2017
- Detect size automatically like other PutObject() operations. - Allow progress bar to be passed into PutObjectStreaming(). - Allow also metadata to be passed into PutObjectStreaming(). - Rename NewStreamingV4 to just StreamingV4(). Keeping it consistent with other signature methods.
harshavardhana
force-pushed
the
multipart-streaming
branch
from
f1972e7
to
f9a324a
Compare
krisis
reviewed
Apr 24, 2017
| // If size cannot be found on a stream, it is not possible | ||
| // to upload using streaming signature, fall back to multipart. | ||
| if size < 0 { | ||
| return c.putObjectMultipartStream(bucketName, objectName, reader, size, metadata, progress) |
There was a problem hiding this comment.
@harshavardhana shouldn't we be using c.putObjectMultipartStreamNoChecksum?
krisis
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consistent with other signature methods.