api: Optimize multipart upload memory usage for unknown sized stream #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reviews here @balamurugana @vadmeste ? |
balamurugana
requested changes
Aug 1, 2017
api-put-object-encrypted.go
Outdated
| @@ -42,5 +42,5 @@ func (c Client) PutEncryptedObject(bucketName, objectName string, reader io.Read | |||
| metadata[amzHeaderKey] = []string{encryptMaterials.GetKey()} | |||
| metadata[amzHeaderMatDesc] = []string{encryptMaterials.GetDesc()} | |||
|
|
|||
| return c.putObjectMultipart(bucketName, objectName, encryptMaterials, -1, metadata, progress) | |||
| return c.putObjectMultipartStreamNoLength(bucketName, objectName, encryptMaterials, -1, metadata, progress) | |||
There was a problem hiding this comment.
What is -1 to putObjectMultipartStreamNoLength()?
|
Changes are done @balamurugana - ready to review again. |
balamurugana
reviewed
Aug 2, 2017
api-put-object-multipart.go
Outdated
| prtSize, rErr := hashCopyN(hashAlgos, hashSums, tmpBuffer, reader, partSize) | ||
| if rErr != nil && rErr != io.EOF { | ||
| bufp := bufPool.Get().(*[]byte) | ||
| prtSize, rErr := io.ReadFull(reader, *bufp) |
There was a problem hiding this comment.
length may be better than prtSize
|
|
||
| // Increment part number. | ||
| partNumber++ | ||
|
|
||
| // Put back data into bufpool. | ||
| bufPool.Put(bufp) |
There was a problem hiding this comment.
this statement can be in defer
There was a problem hiding this comment.
We cannot defer @balamurugana we need to get this back in the next loop.
|
@vadmeste need your reviews as well. |
balamurugana
approved these changes
Aug 2, 2017
vadmeste
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730