Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally retry HTTP calls for specific S3 errors #799

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Conditionally retry HTTP calls for specific S3 errors #799

merged 1 commit into from
Aug 29, 2017

Conversation

kannappanr
Copy link
Collaborator

@kannappanr kannappanr commented Aug 25, 2017 •
edited
Loading

Fixes this issue by checking for Invalidregion related s3 error codes like

  1. InvalidRegion
  2. AuthorizationHeaderMalformed

instead of just checking for http.StatusBadRequest when the other conditions are met.
Fixes #795 and #764

balamurugana
balamurugana reviewed Aug 25, 2017
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana
Copy link
Member

balamurugana commented Aug 26, 2017 •
edited
Loading

Overall looks good. You could fix commit log by

Conditionally retry HTTP calls for specific S3 errors

When InvalidRegion or AuthorizationHeaderMalformed error is received from S3 server,
update bucket region cache and retry the same ReST call with returned region.

Fixes #NNN

@kannappanr kannappanr changed the title Handle slash prefixed object name properly, issue 795 Conditionally retry HTTP calls for specific S3 errors Aug 28, 2017
@kannappanr
Copy link
Collaborator Author

Fixes #795 and #764

@kannappanr
Conditionally retry HTTP calls for specific S3 errors
aba3264 
When InvalidRegion or AuthorizationHeaderMalformed error is received from S3 server,
update bucket region cache and retry the same ReST call with returned region.

Fixes minio#795 and minio#764
@kannappanr kannappanr changed the title Conditionally retry HTTP calls for specific S3 errors Conditionally retry HTTP calls for specific S3 errors. Fixes #795 and #764 Aug 28, 2017
@kannappanr kannappanr changed the title Conditionally retry HTTP calls for specific S3 errors. Fixes #795 and #764 Conditionally retry HTTP calls for specific S3 errors Aug 28, 2017
@deekoder deekoder merged commit dcd84a9 into minio:master Aug 29, 2017
@krisis krisis mentioned this pull request Aug 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balamurugana balamurugana balamurugana approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kannappanr @balamurugana @harshavardhana @deekoder