Fix for functional tests using random file sizes with static files (#809) #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
reviewed
Sep 2, 2017
functional_tests.go
Outdated
| @@ -45,7 +45,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| sixtyFiveMiB = 1024 * 1024 * 65 // 65MiB | |||
| sixtyFiveMiB = 1024 * 1024 * 65 // 65MiB | |||
| thirtyThreeKB = 1024 * 33 //33KB | |||
There was a problem hiding this comment.
How about using humanize.MiByte and humanize.KiByte?
kannappanr
force-pushed
the
File_Size_Mismatch
branch
from
d49ea79
to
a878a25
Compare
harshavardhana
requested changes
Sep 2, 2017
There was a problem hiding this comment.
Commit message can be a bit more descriptive like
tests: Use consistent filesize for all test data.
Use the same filesize values for both the random
data reader and corresponding static files for consistent functional test behavior across various testing env.
Fixes #809
Use the same filesize value for both the random data reader and corresponding static files for consistent functional test behavior across various testing env. Fixes minio#809
kannappanr
force-pushed
the
File_Size_Mismatch
branch
from
a878a25
to
e96ffff
Compare
deekoder
requested review from
krisis,
harshavardhana and
poornas
and removed request for
poornas
krisis
approved these changes
Sep 5, 2017
harshavardhana
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue by using the size of the 33KB file instead of random size.
Fixes #809