Avoid setting server encryption headers with x-amz-meta #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
x-amz-meta
branch
from
7dc0497
to
a940d1b
Compare
kannappanr
reviewed
Oct 27, 2017
utils.go
Outdated
| "x-amz-server-side-encryption-customer-key-MD5", | ||
| } | ||
|
|
||
| // isCSEHeader returns true if header is a client side encryption header. |
There was a problem hiding this comment.
Looks like a Typo. Needs to be
isSSEHeader returns true if header is a server side encryption header.
harshavardhana
force-pushed
the
x-amz-meta
branch
from
a940d1b
to
2ea3f42
Compare
kannappanr
reviewed
Oct 27, 2017
utils.go
Outdated
| @@ -255,3 +256,24 @@ func isCSEHeader(headerKey string) bool { | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
| // sseHeaders is list of client side encryption headers | |||
There was a problem hiding this comment.
Comment needs to be
sseHeaders is list of server side encryption headers
harshavardhana
force-pushed
the
x-amz-meta
branch
from
2ea3f42
to
aea6785
Compare
harshavardhana
force-pushed
the
x-amz-meta
branch
from
aea6785
to
5dd6ffd
Compare
poornas
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.