pkg/credentials: Credentials retrieval should prioritize credentials #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
support-chaining
branch
from
9beb659
to
0840f46
Compare
donatello
requested changes
Nov 17, 2017
pkg/credentials/chain.go
Outdated
| @@ -58,28 +56,30 @@ func NewChainCredentials(providers []Provider) *Credentials { | |||
| }) | |||
| } | |||
|
|
|||
| // Retrieve returns the credentials value or error if no provider returned | |||
| // without error. | |||
| // Retrieve returns the credentials value, or no anonymous credentials if | |||
There was a problem hiding this comment.
This comment is quite confusing - s/no anonymous credentials/the anonymous credential value/ perhaps.
harshavardhana
force-pushed
the
support-chaining
branch
from
0840f46
to
a7f2f13
Compare
Always prefer proper credentials over anonymous ones, if no credentials are found default to anonymous value.
harshavardhana
force-pushed
the
support-chaining
branch
from
a7f2f13
to
8699872
Compare
|
Can you review again @nitisht @donatello ? |
donatello
approved these changes
Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always prefer proper credentials over anonymous ones, if no
credentials are found default to anonymous value.