Reduced the number of files in testRemoveMultipleObjects test #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekoder
requested review from
harshavardhana,
krisis and
donatello
and removed request for
krisis
harshavardhana
approved these changes
Nov 22, 2017
There was a problem hiding this comment.
LGTM - The change this brings which we should be aware is 1100 objects were used to test that multi object delete is done in batches, basically our code is able to handle a stream of input data of lot objects but we are making sure we are deleting 1000 at a time.
Since there is no easier way to see that occur or validate, keeping it 200 would work too.
donatello
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced change is to stop gcs server failing with "We encountered an internal error, please try again." when dealing with many files more than it can handle.
Fixes #887