Ignore Body of Responses to HEAD Requests as per Spec #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkleen Could you rebase your PR on master branch so that we can run the updated tests? |
Sorry for the late reply, I'm quite busy with teaching and work Did the rebase, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the HTTP Spec server responses to HEAD Requests must not contain bodies.
Nontheless
minio-hsrelies on the existence of aContent-Typeheader as a heuristic of whether to expect an error message in the body of the response.Some S3 api servers (such as garage adhere to the http spec and produce responses to HEAD requests without bodies but containing a
Content-Typeheader (because an analogousGETrequest would return one).minio-hscurrently fails in such situations.