apply suggestion

minio · Jul 10, 2024 · 1a634ec · 1a634ec
1 parent b0739f2
commit 1a634ec
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/main.go b/main.go
@@ -404,7 +404,9 @@ func (b *Backend) updateCallStats(t shortTraceMsg) {
 	// automatically update the global stats
 	// Read/Write Lock is not required here
 	globalConnStatsRWMutex.RLock()
-	for _, c := range globalConnStats {
+	connStats := globalConnStats
+	globalConnStatsRWMutex.RUnlock()
+	for _, c := range connStats {
 		if c == nil {
 			continue
 		}
@@ -418,7 +420,6 @@ func (b *Backend) updateCallStats(t shortTraceMsg) {
 		c.setTotalCalls(b.Stats.TotCalls)
 		c.setTotalCallFailures(b.Stats.TotCallFailures)
 	}
-	globalConnStatsRWMutex.RUnlock()
 }
 
 type multisite struct {

diff --git a/metrics.go b/metrics.go
@@ -53,8 +53,9 @@ func (c *sidekickCollector) Collect(ch chan<- prometheus.Metric) {
 	// automatically read the global stats
 	// Read/Write Lock is not required here
 	globalConnStatsRWMutex.RLock()
-	defer globalConnStatsRWMutex.RUnlock()
-	for _, c := range globalConnStats {
+	connStats := globalConnStats
+	globalConnStatsRWMutex.RUnlock()
+	for _, c := range connStats {
 		if c == nil {
 			continue
 		}