Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cert/key reload without server restart #108

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Jun 11, 2024

support cert/key reload without server restart
fix #106
how to test:

PS C:\workspace\go\src\sidekick\dist> ./certgen -host "192.168.2.6,127.0.0.1,localhost"             
Created a new certificate 'public.crt', 'private.key' valid for the following names 📜
 - "192.168.2.6"
 - "127.0.0.1"
 - "localhost"
PS C:\workspace\go\src\sidekick\dist> mc alias set sk https://192.168.2.6:8090 minioadmin minioadmin
Fingerprint of sk public key: 2385a69ce94fb9f70e9a53fd5a91310c41c93a394e9ff659877310e20ce7d57b
Confirm public key y/N: y
mc.exe: <ERROR> Unable to initialize new alias from the provided credentials. Get "https://192.168.2.6:8090": tls: failed to verify certificate: x509: certificate signed by unknown authority.
PS C:\workspace\go\src\sidekick\dist> ./certgen -host "127.0.0.1,localhost"                         
Created a new certificate 'public.crt', 'private.key' valid for the following names 📜
 - "127.0.0.1"
 - "localhost"
PS C:\workspace\go\src\sidekick\dist> mc alias set sk https://192.168.2.6:8090 minioadmin minioadmin
mc.exe: <ERROR> Unable to initialize new alias from the provided credentials. Get "https://192.168.2.6:8090": tls: failed to verify certificate: x509: certificate is valid for 127.0.0.1, not 192.168.2.6.
PS C:\workspace\go\src\sidekick\dist> 

support cert/key reload without server restart
go version
router
.github/workflows/vulncheck.yml Outdated Show resolved Hide resolved
change version
@jiuker jiuker requested a review from ramondeklein June 11, 2024 14:29
main.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
jiuker and others added 2 commits June 12, 2024 08:20
Co-authored-by: Harshavardhana <harsha@minio.io>
Co-authored-by: Harshavardhana <harsha@minio.io>
main.go Outdated Show resolved Hide resolved
update depend
@harshavardhana harshavardhana merged commit 6c17042 into minio:master Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support auto-reload of certs once replaced using pkg/certs package
4 participants