Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in errorHandler make sure to return the correct error #94

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

harshavardhana
Copy link
Member

error handler currently does not return and has never returned
the error back to the client application for any in-flight requests
that might have failed or canceled.

make sure we return errors back to the client for even transient
in-flight request errors.

@poornas
Copy link
Collaborator

poornas commented Sep 29, 2023

lint check failed

error handler currently does not return and has never returned
the error back to client application for any in-flight requests
that might have failed or canceled.

make sure we return errors back to client for even transient
in-flight request errors.
@harshavardhana
Copy link
Member Author

fixes #64

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

main.go Show resolved Hide resolved
@harshavardhana harshavardhana merged commit e396cd1 into master Sep 29, 2023
5 checks passed
@harshavardhana harshavardhana deleted the error-handler branch September 29, 2023 23:04
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants