Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to filter errors and status codes #95

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Add flags to filter errors and status codes #95

merged 3 commits into from
Nov 6, 2023

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented Nov 2, 2023

Adds --errors and --status-code to filter traces for errors or specific status codes.

@r-scheele
Copy link

@harshavardhana PTAL?

kannappanr
kannappanr approved these changes Nov 6, 2023
View reviewed changes
Copy link

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 779bde0 into minio:master Nov 6, 2023
4 checks passed
@taran-p taran-p deleted the filters branch November 6, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr kannappanr approved these changes

@r-scheele r-scheele Awaiting requested review from r-scheele

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taran-p @r-scheele @harshavardhana @kannappanr