Fix hang at end of distributed warp with influxdb #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running distributed warp with
--influxdb
, the app would always hang at the end of each run. After investigation, it appears this is because the channel used to send operations to Influx isn't used on the master process and thus, never gets closed. The app then hangs on the global wait group waiting for the influx goroutine to complete.As a fix, I closed the
ExtraOut
channels after therunServerBenchmark
completes. Alternatively, you could not start the influx channel on the master node.