London-NonLondon Feature Branch #7263
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del. New attribute is set to be a boolean, with null values enabled to not break compatibility with existing claim entries.
…eck for London Fees field
… are now functional and will store a true or false value in the created claim.
*** Some tweaks to make cucumber tests work properly *** Added a test to claims_controller_spec.rb to confirm that the new attribute is working in the backend.
…ge. Failing as expected.
london_rates_apply added as an optional param to common_lgfs_params in claim_params_helper.rb which cascades down to the individual API endpoints
** added new helper method to base_validator ** added validation method to base_claim validator ** added param to litigator final claims validation only for now; TODO for late add it to other litigator claim types ** translations added to claim.yml
** Created new custom validation in Grape for optional booleans ** Tweaked and expanded unit tests
** Expanded step validation specs to include the new attribute
** Neatened summary row code to make it multiple smaller lines ** Added london_rates_apply summary line to the accordion for submitted claims ** Nils now have a default message
** Step validation hadn't been activated for some LGFS claim types, fixed that
** Tests within shared_examples_for_api.rb covering london rates refactored to use shared examples to avoid use of skip for AGFS claim types ** New shared examples included in all LGFS claim type specs
…del. New attribute is set to be a boolean, with null values enabled to not break compatibility with existing claim entries.
|
Rebased from master- 12/08/2024 |
** Wording for review page null scenario reviewed with designer and amended to be a bit vaguer due to high number of potential scenarios.
…es-Front-end' into London-NonLondon-Feature-Branch # Conflicts: # db/schema.rb
…es-CCCD-API' into London-NonLondon-Feature-Branch
** Request spec set up for Prices Controller, currently only testing london_rates cases
** Prices Controller can now submit API requests for london prices when given a claim with London Rates Apply set
** New feature tests created for london/nonlondon rates on LGFS misc fees
** Modify LGFS misc fees form to use dropdown, quantity and rate fields ** Modify fee_type_code_for to not return LIT_FEE for LGFS misc fees ** New quantity identifier in LGFSMiscFeeSection
** Some tweaks and changes to scope to make new misc fee featuretests work ** Recorded VCRs for new misc fee tests ** Fixed unused materials 3 hours warning to new JS version ** Minor rubocop tweaks and some additional comments for code clarity
** Whitespace and naming cleanup
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged. Draft PR to activate tests runs on this branch when merging ticket branches in