Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence variable #44

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Remove dependence variable #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,13 @@ module "cert_manager" {

cluster_domain_name = data.terraform_remote_state.cluster.outputs.cluster_domain_name
hostzone = terraform.workspace == local.live_workspace ? "*" : data.terraform_remote_state.cluster.outputs.hosted_zone_id

# This module requires Prometheus to be already deployed
dependence_prometheus = module.prometheus.helm_prometheus_operator_status
}
```

## Inputs

| Name | Description | Type | Default | Required |
|-----------------------------|---------------------------------------------------------------|:--------:|:-------:|:--------:|
| dependence_prometheus | Prometheus Dependence variable | string | | yes |
| hostzone | To solve ACME Challenges. Scope should be limited to hostzone. If star (*) is used certmanager will control all hostzones | string | | yes |
| cluster_domain_name | Value used for externalDNS annotations and certmanager | string | | yes |
| eks_cluster_oidc_issuer_url | The OIDC issuer URL from the cluster, it is used for IAM ServiceAccount integration | string | | no |
Expand Down
4 changes: 0 additions & 4 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ resource "helm_release" "cert_manager" {
eks_service_account = module.iam_assumable_role_admin.this_iam_role_arn
})]

depends_on = [
var.dependence_prometheus,
]

lifecycle {
ignore_changes = [keyring]
}
Expand Down
2 changes: 0 additions & 2 deletions test/cert-manager.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,4 @@ module "cert_manager" {

cluster_domain_name = "cert-manager.cloud-platform.service.justice.gov.uk"
hostzone = ["AAATEST"]

dependence_prometheus = "ignore"
}
4 changes: 0 additions & 4 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
variable "dependence_prometheus" {
description = "Prometheus module dependences in order to be executed."
}

variable "cluster_domain_name" {
description = "The cluster domain used for externalDNS annotations and certmanager"
}
Expand Down
Loading