-
Notifications
You must be signed in to change notification settings - Fork 3
Add an example to decode the ECR secrets #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one very minor nitpick, LGTM.
01-getting-started/003-ecr-setup.md
Outdated
@@ -74,6 +74,11 @@ kubectl -n <namespace_name> get secret example-team-ecr-credentials-output -o ya | |||
|
|||
The values in kubernetes `Secrets` are always `base64` encoded so you will have to decode them before you can use them outside kubernetes. Inside the cluster, the nodes already have access to the ECR so you don't need to make any changes. | |||
|
|||
This can be done at the command line using the following: | |||
``` | |||
echo `echo QWxhZGRpbjpvcGVuIHNlc2FtZQ== | base64 --decode` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This syntax seems a little confusing. If all you want is an extra carriage return at the end, how about this instead?
echo QWxhZGRpbjpvcGVuIHNlc2FtZQ== | base64 --decode; echo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other option is to provide a link to the Authenticating with the repository in the next steps of this page?
Not sure on the preferred flow of the steps?
Welcome back by the way! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got another PR, #115 , which makes some changes to the walkthrough of deploying an application, so it's probably best to keep this as an example of using base64
for now, in case the other change breaks the link.
(And thanks, it's good to be back).
As I've had to run this a few times and have to keep googling it... Note: the example text decodes to `Aladdin:open sesame` and is not an actual secret
1f2594a
to
d7138cb
Compare
This has been hanging around for a while, so I'm updating it to use the suggested syntax and merging it. |
As I've had to run this a few times and have to keep googling it...
Note: the example text decodes to
Aladdin:open sesame
and is notan actual secret