Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(deps): Bump govuk-components from 4.1.2 to 5.0.0 #715

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Bumps govuk-components from 4.1.2 to 5.0.0.

Release notes

Sourced from govuk-components's releases.

Version 5.0.0

Draft release notes

⚠️ This is a breaking change release

Version 5.0.0 of the ruby govuk-components gem supports version 5.0.0 of the govuk-frontend npm package. Both contain breaking changes, and are dependent on each other – so you should update both at the same time.

These release notes for the ruby gem should be read alongside the release notes for govuk-frontend.

Upgrade instructions

1. Install both the gem AND the node package

Update the version of govuk-component in your Gemfile and run bundle install:

gem "govuk-components", "~> 5.0.0b4"

Update your version of govuk-frontend in your package.json and then run npm install or yarn install (depending on which you use).

"govuk-frontend": "5.0.0-beta.2",

2. Check that your app still builds

The way that assets have been packaged in govuk-frontend has changed, so you may need to update your build process.

If you're using Sass, change

@import "govuk-frontend/govuk/all";

to

@import "govuk-frontend/dist/govuk/all";

If you are using a javascript compiler, change govuk-frontend/govuk to govuk-frontend/dist/govuk.

See release notes for govuk-frontend 5.0.0 for details.

3. Update your application layout file

In your application layout file (normally layouts/application.html.erb), update the code snippet which adds a class to the document body.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot requested a review from a team as a code owner December 11, 2023 03:20
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 11, 2023
@dependabot dependabot bot force-pushed the dependabot/bundler/govuk-components-5.0.0 branch from d704cb4 to de8e7aa Compare December 12, 2023 13:56
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and have tested with no breakages however the tags styling has changed or needs attention:

Old tag styling

Screenshot 2023-12-12 at 16 59 51

Screenshot 2023-12-12 at 17 00 02

Tag styling on branch

Screenshot 2023-12-12 at 17 00 18

Screenshot 2023-12-12 at 17 00 25

@jsugarman jsugarman self-requested a review December 12, 2023 19:58
@jsugarman
Copy link
Contributor

jsugarman commented Dec 12, 2023

Looks good and have tested with no breakages however the tags styling has changed or needs attention:

Old tag styling
Tag styling on branch

Actually, this has been done deliberately done as part of this PR , so all good.

dependabot bot and others added 2 commits December 13, 2023 08:19
Bumps [govuk-components](https://github.com/x-govuk/govuk-components) from 4.1.2 to 5.0.0.
- [Release notes](https://github.com/x-govuk/govuk-components/releases)
- [Commits](x-govuk/govuk-components@v4.1.2...v5.0.0)

---
updated-dependencies:
- dependency-name: govuk-components
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@agoldstone93 agoldstone93 force-pushed the dependabot/bundler/govuk-components-5.0.0 branch from 2c45d3c to 25a0c79 Compare December 13, 2023 08:20
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 13, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@agoldstone93 agoldstone93 reopened this Dec 13, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@agoldstone93 agoldstone93 merged commit 8637a46 into main Dec 13, 2023
9 checks passed
@agoldstone93 agoldstone93 deleted the dependabot/bundler/govuk-components-5.0.0 branch December 13, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants