CCMSPUI-453: Fix issue with closed notifications specification (#127)

* Added reference summary to open-api-specification.yml Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * Added CaseReferenceController and NewCaseReferenceRepository Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * CCMSPUI-378: Added CaseReferenceSummaryMapper and further tests Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * CCMSPUI-378: Removed CaseReferenceSummaryMapper.java Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * CCMSPUI-378: Fixed checkstyle issue in NewCaseReferenceService Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * CCMSPUI-453: Work towards endpoint and NotificationsMapper including mapping XML values Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * CCMSPUI-453: Fix to NotificationsMapper when XML is empty Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * CCMSPUI-453: Fixes to codestyle violations Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * Started on IT for NotificationRepository Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * Added NotificationSpecification to help with filtering Notification entities in NotificationRepository Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * CCMSPUI-453: Tweaks to open-api-specification.yml, and NotificationControllerTests Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * CCMSPUI-453: NotificationServiceTest and additional JavaDoc Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * Fix issue with NotificationSpecification Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> * Fix to test Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk> --------- Signed-off-by: Jamie Briggs <jamie.briggs@digital.justice.gov.uk>
ministryofjustice · Dec 20, 2024 · 6a1035d · 6a1035d
1 parent 596c62d
commit 6a1035d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ationTest/java/uk/gov/laa/ccms/data/repository/NotificationRepositoryIntegrationTest.java b/...ationTest/java/uk/gov/laa/ccms/data/repository/NotificationRepositoryIntegrationTest.java
@@ -264,7 +264,7 @@ void shouldFilterByNotificationType(){
         null,
         null,
         null,
-        false, "N",
+        true, "N",
         null,
         null);
     // When

diff --git a/...rc/main/java/uk/gov/laa/ccms/data/repository/specification/NotificationSpecification.java b/...rc/main/java/uk/gov/laa/ccms/data/repository/specification/NotificationSpecification.java
@@ -87,7 +87,7 @@ public static Specification<Notification> withFilters(
         predicates.add(criteriaBuilder.equal(root.get("feeEarnerPartyId"), feeEarnerId));
       }
       if (!includeClosed) {
-        predicates.add(criteriaBuilder.isTrue(root.get("isOpen")));
+        predicates.add(criteriaBuilder.equal(root.get("isOpen"), "true"));
       }
       if (notificationType != null) {
         predicates.add(criteriaBuilder.equal(root.get("actionNotificationInd"), notificationType));
-Original file line number
+Diff line change
@@ Expand Up / @@ -264,7 +264,7 @@ void shouldFilterByNotificationType(){ @@
             null,
             null,
             null,
-            false, "N",
+            true, "N",
             null,
             null);
         // When
@@ Expand Down @@