Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCMSPUI-453: Fix issue with closed notifications specification #127

Merged
merged 18 commits into from
Dec 20, 2024
Merged

CCMSPUI-453: Fix issue with closed notifications specification #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3a5c06f
Added reference summary to open-api-specification.yml
JamieBriggs-MoJ Dec 10, 2024
af29e97
Added CaseReferenceController and NewCaseReferenceRepository
JamieBriggs-MoJ Dec 10, 2024
70d39c3
CCMSPUI-378: Added CaseReferenceSummaryMapper and further tests
JamieBriggs-MoJ Dec 11, 2024
eb151aa
CCMSPUI-378: Removed CaseReferenceSummaryMapper.java
JamieBriggs-MoJ Dec 12, 2024
00db881
CCMSPUI-378: Fixed checkstyle issue in NewCaseReferenceService
JamieBriggs-MoJ Dec 12, 2024
db906f0
Merge branch 'main' into story/ccmspui-453_get_notifications_endpoint
JamieBriggs-MoJ Dec 12, 2024
1c3b019
CCMSPUI-453: Work towards endpoint and NotificationsMapper including …
JamieBriggs-MoJ Dec 16, 2024
bc4cb34
CCMSPUI-453: Fix to NotificationsMapper when XML is empty
JamieBriggs-MoJ Dec 16, 2024
71bc49a
CCMSPUI-453: Fixes to codestyle violations
JamieBriggs-MoJ Dec 16, 2024
6dafc43
Merge branch 'main' into story/ccmspui-453_get_notifications_endpoint
JamieBriggs-MoJ Dec 17, 2024
d950a14
Started on IT for NotificationRepository
JamieBriggs-MoJ Dec 17, 2024
2799af6
Added NotificationSpecification to help with filtering Notification e…
JamieBriggs-MoJ Dec 17, 2024
57805eb
CCMSPUI-453: Tweaks to open-api-specification.yml, and NotificationCo…
JamieBriggs-MoJ Dec 17, 2024
c9b4646
CCMSPUI-453: NotificationServiceTest and additional JavaDoc
JamieBriggs-MoJ Dec 17, 2024
aad8c5a
Merge branch 'main' into story/ccmspui-453_get_notifications_endpoint
JamieBriggs-MoJ Dec 18, 2024
2090584
Fix issue with NotificationSpecification
JamieBriggs-MoJ Dec 19, 2024
7e9a4d6
Merge branch 'main' into story/ccmspui-453_get_notifications_endpoint
JamieBriggs-MoJ Dec 19, 2024
ccd49bf
Fix to test
JamieBriggs-MoJ Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ationTest/java/uk/gov/laa/ccms/data/repository/NotificationRepositoryIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ void shouldFilterByNotificationType(){
null,
null,
null,
false, "N",
true, "N",
null,
null);
// When
Expand Down
2 changes: 1 addition & 1 deletion ...rc/main/java/uk/gov/laa/ccms/data/repository/specification/NotificationSpecification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public static Specification<Notification> withFilters(
predicates.add(criteriaBuilder.equal(root.get("feeEarnerPartyId"), feeEarnerId));
}
if (!includeClosed) {
predicates.add(criteriaBuilder.isTrue(root.get("isOpen")));
predicates.add(criteriaBuilder.equal(root.get("isOpen"), "true"));
}
if (notificationType != null) {
predicates.add(criteriaBuilder.equal(root.get("actionNotificationInd"), notificationType));
Expand Down
Loading