Upgrade json_api_client #2436
Merged
Upgrade json_api_client #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of json_api_client removes faraday_middleware to enable compatibility with both version 1 and 2 of Faraday. However, faraday_middleware is still required for the FaradaMiddleware::OAuth2. This causes conflicts as json_api_client attempts to load middleware for JSON that exists both in the faraday and faraday_middleware gems. Version 1.2.1 of the faraday_middleware fixes this and ensures that the built in version of middleware is favoured.
|
mpw5
approved these changes
Sep 24, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Upgrade
json_api_clientandfaraday_middlewaretogether.Ticket
N/A
Why
json_api_clienthas been updated to allow compatibility with both version 1 and 2 of Faraday. To do this thefaraday_middlewaregem was removed as this is not compatible with Faraday version 2. To facilitate this some middleware has been built in to Faraday 1 to mirror the behaviour of version 2. This has been done for the JSON firmware, whichjson_api_clientuses, but not for the OAuth2 middleware, which we still require. Simply addingfaraday_middlewareback in for the OAuth2 middleware causes conflicts as the JSON middleware exists twice.How
Add
faraday_middlewareand require at least version 1.2.1. This version has been fixed (lostisland/faraday#1595) to resolve conflicts and favours the built in version of any middleware that also exists infaraday_middleware.