Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial attempt to create pagerduty orchestration for sprinkler #7912

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Initial attempt to create pagerduty orchestration for sprinkler #7912

merged 3 commits into from
Sep 12, 2024

Conversation

SteveLinden
Copy link
Contributor

Again based on the call #5980

This is an attempt to create orchestration on pager duty. It will, initially, just be on the creation of the code.

I have had to include the team in there so there may be other versions in the future.

@SteveLinden SteveLinden requested a review from a team as a code owner September 12, 2024 10:27
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty

Running Trivy in terraform/pagerduty
2024-09-12T10:29:22Z INFO [db] Need to update DB
2024-09-12T10:29:22Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-12T10:29:25Z INFO [vuln] Vulnerability scanning is enabled
2024-09-12T10:29:25Z INFO [misconfig] Misconfiguration scanning is enabled
2024-09-12T10:29:25Z INFO Need to update the built-in policies
2024-09-12T10:29:25Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-12T10:29:25Z INFO [secret] Secret scanning is enabled
2024-09-12T10:29:25Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-12T10:29:25Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-12T10:29:25Z INFO [terraform scanner] Scanning root module file_path="."
2024-09-12T10:29:25Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="pagerduty_token, pagerduty_user_token"
2024-09-12T10:29:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="pagerduty_team_membership.modernisation_platform_membership" value="cty.NilVal"
2024-09-12T10:29:25Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:5-16"
2024-09-12T10:29:25Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:101-110"
2024-09-12T10:29:25Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:115-124"
2024-09-12T10:29:25Z INFO Number of language-specific files num=0
2024-09-12T10:29:25Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-09-12T10:29:22Z	INFO	[db] Need to update DB
2024-09-12T10:29:22Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-12T10:29:25Z	INFO	[vuln] Vulnerability scanning is enabled
2024-09-12T10:29:25Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-09-12T10:29:25Z	INFO	Need to update the built-in policies
2024-09-12T10:29:25Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-12T10:29:25Z	INFO	[secret] Secret scanning is enabled
2024-09-12T10:29:25Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-12T10:29:25Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-12T10:29:25Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-09-12T10:29:25Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="pagerduty_token, pagerduty_user_token"
2024-09-12T10:29:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="pagerduty_team_membership.modernisation_platform_membership" value="cty.NilVal"
2024-09-12T10:29:25Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:5-16"
2024-09-12T10:29:25Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:101-110"
2024-09-12T10:29:25Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:115-124"
2024-09-12T10:29:25Z	INFO	Number of language-specific files	num=0
2024-09-12T10:29:25Z	INFO	Detected config files	num=3
trivy_exitcode=0

davidkelliott
davidkelliott reviewed Sep 12, 2024
View reviewed changes
terraform/pagerduty/member-services-integrations.tf Outdated Show resolved Hide resolved
terraform/pagerduty/member-services-integrations.tf Outdated

resource "pagerduty_event_orchestration" "monitor-sprinkler-integration" {
depends_on = [ pagerduty_team.sprinkler-development ]
name = "My Monitoring Orchestration of Sprinkler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this orchestration can be left here for the team to use to test future pagerduty changes. Could you name it and the description something to reflect that, eg name="sprinkler-development-integration" description="Integrates sprinkler-development account with PagerDuty" thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have amended the description to the one you suggested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have put the description in the name field and the description is still the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

terraform/pagerduty/member-services-integrations.tf Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty

Running Trivy in terraform/pagerduty
2024-09-12T11:24:34Z INFO [db] Need to update DB
2024-09-12T11:24:34Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-12T11:24:36Z INFO [vuln] Vulnerability scanning is enabled
2024-09-12T11:24:36Z INFO [misconfig] Misconfiguration scanning is enabled
2024-09-12T11:24:36Z INFO Need to update the built-in policies
2024-09-12T11:24:36Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-12T11:24:36Z INFO [secret] Secret scanning is enabled
2024-09-12T11:24:36Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-12T11:24:36Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-12T11:24:37Z INFO [terraform scanner] Scanning root module file_path="."
2024-09-12T11:24:37Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="pagerduty_token, pagerduty_user_token"
2024-09-12T11:24:37Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="pagerduty_team_membership.modernisation_platform_membership" value="cty.NilVal"
2024-09-12T11:24:37Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:5-16"
2024-09-12T11:24:37Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:101-110"
2024-09-12T11:24:37Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:115-124"
2024-09-12T11:24:37Z INFO Number of language-specific files num=0
2024-09-12T11:24:37Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-09-12T11:24:34Z	INFO	[db] Need to update DB
2024-09-12T11:24:34Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-12T11:24:36Z	INFO	[vuln] Vulnerability scanning is enabled
2024-09-12T11:24:36Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-09-12T11:24:36Z	INFO	Need to update the built-in policies
2024-09-12T11:24:36Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-12T11:24:36Z	INFO	[secret] Secret scanning is enabled
2024-09-12T11:24:36Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-12T11:24:36Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-12T11:24:37Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-09-12T11:24:37Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="pagerduty_token, pagerduty_user_token"
2024-09-12T11:24:37Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="pagerduty_team_membership.modernisation_platform_membership" value="cty.NilVal"
2024-09-12T11:24:37Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:5-16"
2024-09-12T11:24:37Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:101-110"
2024-09-12T11:24:37Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:115-124"
2024-09-12T11:24:37Z	INFO	Number of language-specific files	num=0
2024-09-12T11:24:37Z	INFO	Detected config files	num=3
trivy_exitcode=0

@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty

Running Trivy in terraform/pagerduty
2024-09-12T12:54:06Z INFO [db] Need to update DB
2024-09-12T12:54:06Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-12T12:54:09Z INFO [vuln] Vulnerability scanning is enabled
2024-09-12T12:54:09Z INFO [misconfig] Misconfiguration scanning is enabled
2024-09-12T12:54:09Z INFO Need to update the built-in policies
2024-09-12T12:54:09Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-12T12:54:09Z INFO [secret] Secret scanning is enabled
2024-09-12T12:54:09Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-12T12:54:09Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-12T12:54:10Z INFO [terraform scanner] Scanning root module file_path="."
2024-09-12T12:54:10Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="pagerduty_token, pagerduty_user_token"
2024-09-12T12:54:10Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="pagerduty_team_membership.modernisation_platform_membership" value="cty.NilVal"
2024-09-12T12:54:10Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:5-16"
2024-09-12T12:54:10Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:101-110"
2024-09-12T12:54:10Z INFO [terraform executor] Ignore finding rule="aws-ssm-secret-use-customer-key" range="aws.tf:115-124"
2024-09-12T12:54:10Z INFO Number of language-specific files num=0
2024-09-12T12:54:10Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-09-12T12:54:06Z	INFO	[db] Need to update DB
2024-09-12T12:54:06Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-09-12T12:54:09Z	INFO	[vuln] Vulnerability scanning is enabled
2024-09-12T12:54:09Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-09-12T12:54:09Z	INFO	Need to update the built-in policies
2024-09-12T12:54:09Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-09-12T12:54:09Z	INFO	[secret] Secret scanning is enabled
2024-09-12T12:54:09Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-09-12T12:54:09Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.55/docs/scanner/secret#recommendation for faster secret detection
2024-09-12T12:54:10Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-09-12T12:54:10Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="pagerduty_token, pagerduty_user_token"
2024-09-12T12:54:10Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="pagerduty_team_membership.modernisation_platform_membership" value="cty.NilVal"
2024-09-12T12:54:10Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:5-16"
2024-09-12T12:54:10Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:101-110"
2024-09-12T12:54:10Z	INFO	[terraform executor] Ignore finding	rule="aws-ssm-secret-use-customer-key" range="aws.tf:115-124"
2024-09-12T12:54:10Z	INFO	Number of language-specific files	num=0
2024-09-12T12:54:10Z	INFO	Detected config files	num=3
trivy_exitcode=0

davidkelliott
davidkelliott approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@davidkelliott davidkelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SteveLinden SteveLinden added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit b84b840 Sep 12, 2024
5 checks passed
@SteveLinden SteveLinden deleted the feature/sprinkler-orchestration branch September 12, 2024 13:27
@SteveLinden SteveLinden mentioned this pull request Sep 12, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkelliott davidkelliott davidkelliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveLinden @davidkelliott