-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial changes #8158
Initial changes #8158
Conversation
|
|
|
|
|
|
|
terraform/pagerduty/aws.tf
Outdated
delius_mis_prod_alarms = pagerduty_service_integration.delius_mis_prod.integration_key | ||
laa_edw_nonprod_alarms = pagerduty_service_integration.edw_non_prod.integration_key | ||
laa_edw_prod_alarms = pagerduty_service_integration.edw_prod.integration_key | ||
cdpt_ifs_cloudwatch_routing_key = pagerduty_event_orchestration_integration.cdpt_ifs_cloudwatch_integration.parameters[0].routing_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove _routing_key from cdpt_ifs_cloudwatch_routing_key. to cdpt-ifs-alarms as that's how they call it in the environments file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
routing_key removed and code re-pushed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct code re-pushed
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes made to just the cdpt part of the code as it was not working and was incorrect. This was corrected (no "_integrations" in the pagerduty_event_orchestration_integration code.
This was amended and the plan ran successfully. I will push this and ensure that the plan/apply is successful.
Next changes will be in another PR.