Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-2732: Run Lambda in container image and enable integration tests #117

Closed
wants to merge 4 commits into from

Conversation

ntse
Copy link
Contributor

@ntse ntse commented Apr 12, 2024

Purpose

Improve resilience of service by adding integration tests. Make consistent with other services by converting to container image rather than using Lambda ZIP files.

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • I have updated documentation where relevant
  • I have added tests to prove my work
  • I have run the integration tests (results below)

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file docker python labels Apr 19, 2024
@github-actions github-actions bot removed the docker label Apr 22, 2024
@ntse ntse marked this pull request as ready for review April 22, 2024 15:31
@ntse ntse requested a review from a team as a code owner April 22, 2024 15:31
@ntse ntse marked this pull request as draft April 22, 2024 15:31
@ntse ntse changed the title UML-2732: Testing building at image UML-2732: Run Lambda in container image and enable integration tests Apr 23, 2024
@ntse ntse marked this pull request as ready for review April 25, 2024 10:57
@nickdavis2001
Copy link
Contributor

need to start from a different branch

@ntse ntse reopened this Apr 30, 2024
@ntse ntse closed this May 2, 2024
@ntse ntse deleted the UML-2732 branch May 2, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions python terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants