Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/36 #37

Merged
merged 1 commit into from
Nov 12, 2022
Merged

bugfix/36 #37

merged 1 commit into from
Nov 12, 2022

Conversation

isaacismaelx14
Copy link
Contributor

Issue Info

JIRA

Code Review Checklist for Authors

  • Update your branch with the latest changes from develop.
  • Verify all the checks are passed (if applicable).
  • Use code conventions and best practices.
  • New features must have compatibility for a11y (Accessibility).
  • No unintentional console.logs left behind after debugging.
  • Notify the code reviewers on time to have an efficient review time.

Code Review Checklist for Reviewers

  • Take some time to understand the code you are reading.
  • Use an inquisitive tone, do not make an order.
  • Accept that many programming decisions are opinions. Engage a discussion and reach a resolution quickly.
  • Seek to understand the author’s perspective.

In case something is not applied, justify the reason why you skip one of the points above

@isaacismaelx14 isaacismaelx14 self-assigned this Nov 12, 2022
@isaacismaelx14 isaacismaelx14 marked this pull request as ready for review November 12, 2022 14:28
@isaacismaelx14 isaacismaelx14 merged commit 59943a3 into develop Nov 12, 2022
@isaacismaelx14 isaacismaelx14 deleted the bugfix/36 branch November 12, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@isaacismaelx14 isaacismaelx14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@isaacismaelx14