Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"char" is a valid username #149

Closed
jomo opened this issue Feb 4, 2015 · 6 comments
Closed

"char" is a valid username #149

jomo opened this issue Feb 4, 2015 · 6 comments
Assignees
Milestone

Comments

@jomo
Copy link

jomo commented Feb 4, 2015

This guy named "baumans" changed their name to "Char": https://api.mojang.com/user/profiles/f2e9994f94934e08974e2f4b7f7843ea/names

That makes char a valid username. They also have a valid skin: http://skins.minecraft.net/MinecraftSkins/Char.png

You might want to change the default skin name to "Steve", that's not taken and I guess Mojang prevents people from using that name.

This is going to be a breaking change and I'm not sure how you can solve it properly.


You could, of course, keep it as it is, but then the user char would never see their avatar.

@jomo
Copy link
Author

jomo commented Feb 4, 2015

Seems like not many things are using the "char" hardcoded.

@LukeHandle LukeHandle modified the milestone: Release-2.8 Mar 2, 2015
@LukeHandle LukeHandle self-assigned this Mar 2, 2015
@LukeHandle
Copy link
Member

What a pain. I'm inclined to change the hardcoded name to "Steve" as you say because it more accurately reflects the Steve vs. Alex characters, but then again, a single user who has a Steve skin vs. a few websites which are still relying char.

I think if we can be sure that Steve is unobtainable by players as a name it makes more sense to begin a transition to it and possibly in X months we can remove the char override.

@LukeHandle LukeHandle modified the milestones: Release-2.8, Release-2.9 Mar 4, 2015
@jomo
Copy link
Author

jomo commented Mar 4, 2015

yes. I mean no

@LukeHandle
Copy link
Member

The solution being then "MHF_Steve" as the username which we can safely guarantee is and will stay correct. Still feel sad about getting rid of char...

@jomo
Copy link
Author

jomo commented Sep 13, 2015

Yep. That's what we will do at Crafatar, too (crafatar/crafatar#142).
Also note there is a slight difference between the original 'char' and the 'steve' avatar (char has a stronger beard).

@LukeHandle
Copy link
Member

We switched to the new one (without beard) back here minotar/minecraft#2 And yeah, I think I'll add some tracking for char, I can't see us ever fully deprecating it though. I'm expecting the majority of requests are for Steve by a long way and not for the legacy user.

LukeHandle added a commit that referenced this issue Oct 10, 2015
"char" is a legacy account and deprecating its use makes sense as discussed in #149
LukeHandle added a commit that referenced this issue Oct 10, 2015
Configurable logging level (default in config is NOTICE, if not set will default t
  DEBUG will show skin failures
  INFO will log individual requests
  NOTICE will show useful start information and be fairly quiet
Adjust the way stats are reported, add an errored section #159
  Requested is recorded as soon as we establish what is desired (before anything i
  Errors are recorded when we fail to fetch a skin or we have an internal error
Add CORS headers to all responses #167
Handle "MHF_Steve" internally to deprecate "char" #149
LukeHandle added a commit that referenced this issue Oct 10, 2015
Configurable logging level (default in config is NOTICE, if not set will default to INFO) #123
  DEBUG will show skin failures
  INFO will log individual requests
  NOTICE will show useful start information and be fairly quiet
Adjust the way stats are reported, add an errored section #159
  Requested is recorded as soon as we establish what is desired (before anything is returned)
  Errors are recorded when we fail to fetch a skin or we have an internal error
Add CORS headers to all responses #167
Handle "MHF_Steve" internally to deprecate "char" #149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants